Interactive SCCharts #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual rendering for rel cons is not done yet
moved node and the node the relative constraint would refer to are highlighted red
arrow indicates whether the node will be successor or predecessor of another node
shadow attribute of the moved node must be set while rendering the visualization
adjacent nodes can not have rel cons. THe position markers are therefore not filled when the target of the rel cons is an adjacent node
Drakae
reviewed
Nov 1, 2022
| let curPos = getPositionInLayer(layerNodes, target) | ||
| let curPos = getPositionInLayer(layerNodes, target, direction) | ||
|
|
||
| // determine reative constraint |
soerendomroes
commented
Nov 4, 2022
| @@ -43,26 +44,27 @@ export function renderHierarchyLevel(nodes: KNode[], root: KNode): VNode { | |||
| // determines whether only the layer constraint will be set when the node is released | |||
| let onlyLC = shouldOnlyLCBeSet(selNode, layers, direction) && selNode.properties.layerId !== currentLayer | |||
|
|
|||
| let curLayer = null | |||
There was a problem hiding this comment.
@Drakae Why do you need curLayer. Why is currentLayer not enough? Since it is null per default?
There was a problem hiding this comment.
i dont know, it seems unnecessary to me
There was a problem hiding this comment.
Maybe you need this since the currentLayer might be -1 or one higher than the existing layer and you want to return null instead in these cases.
soerendomroes
commented
Nov 4, 2022
Comment on lines
+125
to
+142
| // cons is undefined if target is an adjacent node. If this is the case, the circle should not be filled | ||
| let fill = cons !== undefined ? cons.relCons !== RelCons.UNDEFINED && curPos === i + shift : curPos === i + shift | ||
| let node = layerNodes[i] | ||
| // at the old position of the selected node should not be a circle | ||
| if (!node.selected && !layerNodes[i + 1].selected) { | ||
| // coordinates for both inspected nodes | ||
| let nodeY = node.position.y | ||
| let nodeX = node.position.x | ||
| let nextNodeY = layerNodes[i + 1].position.y | ||
| let nextNodeX = layerNodes[i + 1].position.x | ||
| if (node.selected) { | ||
| nodeY = node.shadowY | ||
| nodeX = node.shadowX | ||
| shift = 0 | ||
| fill = cons !== undefined && cons.node.id === layerNodes[i + 1].id && cons.relCons === RelCons.IN_LAYER_PRED_OF | ||
| } else if (layerNodes[i + 1].selected) { | ||
| nextNodeY = layerNodes[i + 1].shadowY | ||
| nextNodeX = layerNodes[i + 1].shadowX | ||
| fill = cons !== undefined && cons.node.id === node.id && cons.relCons === RelCons.IN_LAYER_SUCC_OF | ||
| } |
There was a problem hiding this comment.
@Drakae why is fill even calculated at first? Is will always be overridden by the conditional.
There was a problem hiding this comment.
are you sure that always one of the conditions is true?
Drakae
reviewed
Nov 4, 2022
| @@ -43,26 +44,27 @@ export function renderHierarchyLevel(nodes: KNode[], root: KNode): VNode { | |||
| // determines whether only the layer constraint will be set when the node is released | |||
| let onlyLC = shouldOnlyLCBeSet(selNode, layers, direction) && selNode.properties.layerId !== currentLayer | |||
|
|
|||
| let curLayer = null | |||
There was a problem hiding this comment.
i dont know, it seems unnecessary to me
Comment on lines
+125
to
+142
| // cons is undefined if target is an adjacent node. If this is the case, the circle should not be filled | ||
| let fill = cons !== undefined ? cons.relCons !== RelCons.UNDEFINED && curPos === i + shift : curPos === i + shift | ||
| let node = layerNodes[i] | ||
| // at the old position of the selected node should not be a circle | ||
| if (!node.selected && !layerNodes[i + 1].selected) { | ||
| // coordinates for both inspected nodes | ||
| let nodeY = node.position.y | ||
| let nodeX = node.position.x | ||
| let nextNodeY = layerNodes[i + 1].position.y | ||
| let nextNodeX = layerNodes[i + 1].position.x | ||
| if (node.selected) { | ||
| nodeY = node.shadowY | ||
| nodeX = node.shadowX | ||
| shift = 0 | ||
| fill = cons !== undefined && cons.node.id === layerNodes[i + 1].id && cons.relCons === RelCons.IN_LAYER_PRED_OF | ||
| } else if (layerNodes[i + 1].selected) { | ||
| nextNodeY = layerNodes[i + 1].shadowY | ||
| nextNodeX = layerNodes[i + 1].shadowX | ||
| fill = cons !== undefined && cons.node.id === node.id && cons.relCons === RelCons.IN_LAYER_SUCC_OF | ||
| } |
There was a problem hiding this comment.
are you sure that always one of the conditions is true?
|
This has been superseded by kieler/klighd-vscode#125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.