Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An expression starting with paren ends on close. #65

Merged
merged 3 commits into from
Dec 14, 2019
Merged

An expression starting with paren ends on close. #65

merged 3 commits into from
Dec 14, 2019

Commits on Dec 14, 2019

  1. An expression starting with paren ends on close. 

    BREAKING CHANGE.  If an expession starts with an open parenthesis, the
expression ends on the closing parenthesis (and that outer parenthesis
is not part of the expression.

This fixes cases where an expression is immediately followed by
something that could be part of the expression.

Before this change, calling a function on the result of some
subexpression could be written as `@(a - b).abs()`.  After this
change, that should be changed to `@((a - b).abs())` unless the intent
is to have the result of (a - b) followed by the template string
`.abs()`.

Fixes #64.
    @kaj
    kaj committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    54e6cb1 View commit details
    Browse the repository at this point in the history

  2. Allow more in paren expression. 

    Everything that is allowed in parenthesis inside an expression should
be allowed when that parenthesis is the entire expression.
    @kaj
    kaj committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    7b863fe View commit details
    Browse the repository at this point in the history

  3. Document paren expressions.

    @kaj
    kaj committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    89b7809 View commit details
    Browse the repository at this point in the history