An expression starting with paren ends on close. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE. If an expession starts with an open parenthesis, the expression ends on the closing parenthesis (and that outer parenthesis is not part of the expression. This fixes cases where an expression is immediately followed by something that could be part of the expression. Before this change, calling a function on the result of some subexpression could be written as `@(a - b).abs()`. After this change, that should be changed to `@((a - b).abs())` unless the intent is to have the result of (a - b) followed by the template string `.abs()`. Fixes #64.
Everything that is allowed in parenthesis inside an expression should be allowed when that parenthesis is the entire expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE. If an expression starts with an open parenthesis, the expression ends on the closing parenthesis (and that outer parenthesis is not part of the expression.
This fixes cases where an expression is immediately followed by something that could be part of the expression.
Before this change, calling a function on the result of some subexpression could be written as
@(a - b).abs(). After this change, that should be changed to@((a - b).abs())unless the intent is to have the result of (a - b) followed by the template string.abs().Fixes #64.