Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing Qt6 6.8.0 on Windows #251

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Conversation

MehdiChinoune
Copy link
Contributor

Qt switched to MSVC 2022

Fixes #250

@pcolby
Copy link

pcolby commented Aug 4, 2024

Thanks, should probably update the arch section of the README.md too. Cheers.

@MehdiChinoune
Copy link
Contributor Author

@jurplel

@xavier2k6
Copy link

@jurplel Ping - Can we get a release with this PR?

Official Qt 6.8.0 is almost ready for GA

Also note, there's an option for msvc2022 in Qt 6.7.3 too
https://download.qt.io/online/qtsdkrepository/windows_x86/desktop/qt6_673_msvc2022/

@xavier2k6
Copy link

Qt 6.8.0 has been officially released now.

@Nelson-numerical-software
Run jurplel/install-qt-action/action@v4
  with:
    dir: C:/install/QT6/
    version: 6.8.0
    host: windows
    target: desktop
    arch: win64_msvc2019_64
    install-deps: true
    modules: qtwebengine
    cache: false
    cache-key-prefix: install-qt-action
    add-tools-to-path: true
    set-env: true
    no-qt-binaries: false
    tools-only: false
    aqtversion: ==3.1.*
    py7zrversion: ==0.20.*
    source: false
    documentation: false
    examples: false

WARNING : Specified Qt version "6.8.0" did not exist when this version of aqtinstall was released. This may not install properly, but we will try our best.

Qt 6.8.0 seems to be not detected.
https://github.com/nelson-lang/nelson/actions/runs/11260113018/job/31310597174

Qt 6.8.0 was released

@jdpurcell
Copy link

    arch: win64_msvc2019_64

@Nelson-numerical-software arch should be win64_msvc2022_64 for Qt 6.8.

@Nelson-numerical-software
    arch: win64_msvc2019_64

@Nelson-numerical-software arch should be win64_msvc2022_64 for Qt 6.8.

Thanks but with win64_msvc2022_64 same trouble:
https://github.com/nelson-lang/nelson/actions/runs/11260751912/job/31312668886

@jdpurcell
Copy link

Thanks but with win64_msvc2022_64 same trouble: https://github.com/nelson-lang/nelson/actions/runs/11260751912/job/31312668886

That helped a little; if you notice the error about packages not found, qt_base was resolved on your newer run. Unfortunately the qtwebengine issue is an upstream problem with aqtinstall I believe.

@MehdiChinoune
Copy link
Contributor Author

Seems like the owner of this repo has abandoned it.

@Nelson-numerical-software
Copy link

Nelson-numerical-software commented Oct 9, 2024

Thanks but with win64_msvc2022_64 same trouble: https://github.com/nelson-lang/nelson/actions/runs/11260751912/job/31312668886

That helped a little; if you notice the error about packages not found, qt_base was resolved on your newer run. Unfortunately the qtwebengine issue is an upstream problem with aqtinstall I believe.

Confirmed without webengine, QT6.8 installed :) (Thanks for your help)

@xavier2k6
Copy link

webengine related issue from upstream aqt -> miurahr/aqtinstall#833

@Edgars-Cirulis
Copy link

Edgars-Cirulis commented Oct 10, 2024

arm64 is borked

image

@jdpurcell
Copy link

arm64 is borked

There is indeed an issue trying to cross-compile ARM64 from an X64 host but it's not install-qt-action's fault. I submitted a PR upstream to aqtinstall.

And I can use my forked repo via install-qt-action's aqtsource parameter so I got an ARM64 project building with just these changes. Note that I had to create a tag w/ a fake version (anything >= 3.0.0) in order to make install-qt-action add the --autodesktop parameter like it's supposed to.

As for compiling from a Windows ARM64 host, no idea, but that's not really a thing yet with GitHub's runners.

@MehdiChinoune
Copy link
Contributor Author

MehdiChinoune commented Oct 10, 2024

Please, everyone. This PR is about fix installing Qt6 6.8.0 on Windows using install-qt-action.
It fixes the issue mentioned in the first post.
Please don't discuss unrelated things here.
If you have an issue discuss elsewhere.
Thanks.

@jurplel
Copy link
Owner

jurplel commented Oct 12, 2024

Thank you for the contribution and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change default arch to win64_msvc2022_64 on Windows with Qt6 6.8.0
8 participants