Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use msvc2022 for Qt 6.7.3 #257

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

Xphalnos
Copy link
Contributor

I propose a small change so that Qt 6.7.3 can use msvc2022. This will not prevent Qt 6.8.0 from using msvc2022.

@pzhlkj6612
Copy link
Contributor

@jurplel jurplel merged commit 08a6bd0 into jurplel:master Oct 23, 2024
@Nerixyz
Copy link
Contributor

Nerixyz commented Nov 9, 2024

I propose a small change so that Qt 6.7.3 can use msvc2022. This will not prevent Qt 6.8.0 from using msvc2022.

Did you test this? aqt doesn't provide a win64_msvc2022_64 arch for 6.7.3. Currently, builds fail when using this action with 6.7.3. There has to be an aqt update before using msvc2022 here.

@pzhlkj6612
Copy link
Contributor

I agree with @Nerixyz. We at least have to update the default version number of aqtisntall as well.

@pzhlkj6612
Copy link
Contributor

pzhlkj6612 commented Nov 10, 2024

... aqt doesn't provide a win64_msvc2022_64 arch for 6.7.3...

We at least have to update the default version number of aqtisntall as well.

The aqt fetches the information of downloadable Qt from the Internet, so I think we should "fix" aqtinstall first, then update the default minimal aqt version number.

Directly reverting the commit is OK, but we still have the choice to wait for aqt's update.

@Nerixyz
Copy link
Contributor

Nerixyz commented Nov 10, 2024

Directly reverting the commit is OK, but we still have the choice to wait for aqt's update.

Yes. It's just a bit unfortunate that installing Qt 6.7.3 is currently broken on Windows with any 4.x version of this action (even 4.0.0). So I'd vote for reverting, adjusting aqt, and then updating aqt and the arch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants