-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass cleanup of temporary dirs if needed #389
Open
fraimondo
wants to merge
3
commits into
main
Choose a base branch
from
enh/bypass_temp_cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−2
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add a ``cleanup`` parameter to the :class:`junifer.pipeline.WorkDirManager`, which allows to disable cleaning up temporary directories by `Fede Raimondo`_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,15 +40,20 @@ class WorkDirManager: | |
The path to the element directory. | ||
root_tempdir : pathlib.Path or None | ||
The path to the root temporary directory. | ||
cleanup : bool | ||
If false, the directories are not cleaned up after the object is | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. false -> False |
||
destroyed. This is useful for debugging purposes. Default is True. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. . Default is True. -> purposes (default True). |
||
""" | ||
|
||
def __init__(self, workdir: Optional[Union[str, Path]] = None) -> None: | ||
def __init__( | ||
self, workdir: Optional[Union[str, Path]] = None, cleanup=True | ||
) -> None: | ||
"""Initialize the class.""" | ||
self._workdir = Path(workdir) if isinstance(workdir, str) else workdir | ||
self._elementdir = None | ||
self._root_tempdir = None | ||
|
||
self._cleanup_dirs = cleanup | ||
self._set_default_workdir() | ||
|
||
def _set_default_workdir(self) -> None: | ||
|
@@ -73,6 +78,8 @@ def __del__(self) -> None: | |
|
||
def _cleanup(self) -> None: | ||
"""Clean up the element and temporary directories.""" | ||
if self._cleanup_dirs is False: | ||
return | ||
# Remove element directory | ||
self.cleanup_elementdir() | ||
# Remove root temporary directory | ||
|
@@ -172,6 +179,8 @@ def delete_element_tempdir(self, tempdir: Path) -> None: | |
The temporary directory path to be deleted. | ||
""" | ||
if self._cleanup_dirs is False: | ||
return | ||
logger.debug(f"Deleting element temporary directory at {tempdir}") | ||
shutil.rmtree(tempdir, ignore_errors=True) | ||
|
||
|
@@ -183,6 +192,8 @@ def cleanup_elementdir(self) -> None: | |
can lead to required intermediate files not being found. | ||
""" | ||
if self._cleanup_dirs is False: | ||
return | ||
if self._elementdir is not None: | ||
logger.debug( | ||
"Deleting element directory at " | ||
|
@@ -245,5 +256,7 @@ def delete_tempdir(self, tempdir: Path) -> None: | |
The temporary directory path to be deleted. | ||
""" | ||
if self._cleanup_dirs is False: | ||
return | ||
logger.debug(f"Deleting temporary directory at {tempdir}") | ||
shutil.rmtree(tempdir, ignore_errors=True) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.