Bypass cleanup of temporary dirs if needed #389
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraimondo
force-pushed
the
enh/bypass_temp_cleanup
branch
from
c3c774f
to
399d443
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 87.52% 87.39% -0.13%
==========================================
Files 129 129
Lines 5332 5341 +9
Branches 857 861 +4
==========================================
+ Hits 4667 4668 +1
- Misses 492 496 +4
- Partials 173 177 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
synchon
requested changes
Nov 6, 2024
| @@ -40,15 +40,20 @@ class WorkDirManager: | |||
| The path to the element directory. | |||
| root_tempdir : pathlib.Path or None | |||
| The path to the root temporary directory. | |||
| cleanup : bool | |||
| @@ -40,15 +40,20 @@ class WorkDirManager: | |||
| The path to the element directory. | |||
| root_tempdir : pathlib.Path or None | |||
| The path to the root temporary directory. | |||
| cleanup : bool | |||
| If false, the directories are not cleaned up after the object is | |||
| @@ -40,15 +40,20 @@ class WorkDirManager: | |||
| The path to the element directory. | |||
| root_tempdir : pathlib.Path or None | |||
| The path to the root temporary directory. | |||
| cleanup : bool | |||
| If false, the directories are not cleaned up after the object is | |||
| destroyed. This is useful for debugging purposes. Default is True. | |||
There was a problem hiding this comment.
. Default is True. -> purposes (default True).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
cleanupparameter to theWorkDirManager, which allows to disable cleaning up temporary directories. While this does not add any important feature to the user, it allows to keep temporary files in case developers want to trace potential issues, mosly when using external tools.