Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription tests and automatically coerce subscription id to string #36

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Subscription tests and automatically coerce subscription id to string #36

wants to merge 8 commits into from

Commits on Jan 21, 2023

  1. test for subscription id

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    5a13fd0 View commit details
    Browse the repository at this point in the history

  2. test subscription creation types

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    44aee9c View commit details
    Browse the repository at this point in the history

  3. force subscription id to str

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    23d3b8d View commit details
    Browse the repository at this point in the history

  4. remove unused default arg for filters

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    954d283 View commit details
    Browse the repository at this point in the history

  5. raise error on wrong type for id

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    622b3eb View commit details
    Browse the repository at this point in the history

  6. clean up subscription tests

    @armstrys
    armstrys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    38bd6ed View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Assert subscription id error is raise properly 

    Co-authored-by: Jeff Thibault <[email protected]>
    @armstrys @jeffthibault
    armstrys and jeffthibault authored Jan 22, 2023
    Configuration menu
    Copy the full SHA
    0132345 View commit details
    Browse the repository at this point in the history

  2. clean up formatting

    @armstrys
    armstrys committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    9f931c0 View commit details
    Browse the repository at this point in the history