Subscription tests and automatically coerce subscription id to string #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those changes both make sense to me! |
Co-authored-by: Jeff Thibault <[email protected]>
|
No worries. This is all helpful to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test that makes sure content in the subscription class is consistent with expected types when converted to json and back. Notably, the current class doesn't force the id to be a string.
I've also removed the default
filtersvalue ofNonesince it is currently unused in the body of the function and isn't a valid option for a subscription - maybe it makes sense to replace this with an emptyFiltersobject instead?