Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure/disable the datastore's ARC cache. #6586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelMure
Copy link
Contributor

Require ipfs/go-ipfs-config#41

This PR allow to change the size or disable the ARC cache in the datastore.

@MichaelMure
Copy link
Contributor Author

MichaelMure commented Aug 20, 2019

Test failure seems unrelated.

@MichaelMure
Copy link
Contributor Author

I'm missing a line to actually pass the config value, will add soon.

@MichaelMure
Copy link
Contributor Author

Fixed, but still require ipfs/go-ipfs-config#41 to build.

@MichaelMure
Copy link
Contributor Author

@Stebalien what about this one ?

@Stebalien
Copy link
Member

Unfortunately, I'm not sure how to add this in a backwards compatible manner (yet). If we add this as-is, the ARC cache will be disabled on all existing nodes as ARCCacheSize will default to 0.

We can ship a migration but I'd hate to do that. I believe the best way to do this is #8776.

@Stebalien Stebalien added the status/blocked Unable to be worked further until needs are met label Nov 16, 2019
@MichaelMure
Copy link
Contributor Author

Make sense to me.

@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label Apr 6, 2021
@Stebalien
Copy link
Member

Revisiting this, we can make progress on this without rewriting the config system. We now have types like config.Flag where we can encode both some type (e.g., a size as a string) or the "default" (null).

Basically, we'd need a new special "size" type with a default option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants