-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure/disable the datastore's ARC cache. #6586
base: master
Are you sure you want to change the base?
Conversation
Test failure seems unrelated. |
I'm missing a line to actually pass the config value, will add soon. |
1e30915
to
979f456
Compare
Fixed, but still require ipfs/go-ipfs-config#41 to build. |
@Stebalien what about this one ? |
Unfortunately, I'm not sure how to add this in a backwards compatible manner (yet). If we add this as-is, the ARC cache will be disabled on all existing nodes as We can ship a migration but I'd hate to do that. I believe the best way to do this is #8776. |
Make sense to me. |
Revisiting this, we can make progress on this without rewriting the config system. We now have types like config.Flag where we can encode both some type (e.g., a size as a string) or the "default" (null). Basically, we'd need a new special "size" type with a default option. |
Require ipfs/go-ipfs-config#41
This PR allow to change the size or disable the ARC cache in the datastore.