Allow to configure/disable the datastore's ARC cache.

ipfs · Sep 6, 2019 · 979f456 · 979f456
1 parent 22532e2
commit 979f456
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/core/node/groups.go b/core/node/groups.go
@@ -122,6 +122,7 @@ func LibP2P(bcfg *BuildCfg, cfg *config.Config) fx.Option {
 func Storage(bcfg *BuildCfg, cfg *config.Config) fx.Option {
 	cacheOpts := blockstore.DefaultCacheOpts()
 	cacheOpts.HasBloomFilterSize = cfg.Datastore.BloomFilterSize
+	cacheOpts.HasARCCacheSize = cfg.Datastore.ARCCacheSize
 	if !bcfg.Permanent {
 		cacheOpts.HasBloomFilterSize = 0
 	}

diff --git a/core/node/storage.go b/core/node/storage.go
@@ -53,7 +53,7 @@ func BaseBlockstoreCtor(cacheOpts blockstore.CacheOpts, nilRepo bool, hashOnRead
 		bs = blockstore.NewBlockstore(rds)
 		bs = &verifbs.VerifBS{Blockstore: bs}
 
-		if !nilRepo {
+		if !nilRepo && (cacheOpts.HasBloomFilterSize > 0 || cacheOpts.HasARCCacheSize > 0) {
 			bs, err = blockstore.CachedBlockstore(helpers.LifecycleCtx(mctx, lc), bs, cacheOpts)
 			if err != nil {
 				return nil, err

diff --git a/docs/config.md b/docs/config.md
@@ -166,6 +166,11 @@ As of writing, [7 hash functions](https://github.com/ipfs/go-ipfs-blockstore/blo
 
 Default: `0`
 
+- `ARCCacheSize`
+A number representing the number of entries of the blockstore's [ARC cache](https://en.wikipedia.org/wiki/Adaptive_replacement_cache). A value of zero represents the feature being disabled.
+
+Default: `65536`
+
 - `Spec`
 Spec defines the structure of the ipfs datastore. It is a composable structure, where each datastore is represented by a json object. Datastores can wrap other datastores to provide extra functionality (eg metrics, logging, or caching).