Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update read me with examples of trivial/non-trivial changes #92

Merged
merged 3 commits into from
Jul 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,22 @@ The [InstructLab Oversight
Committee](https://github.com/instructlab/community/blob/main/MAINTAINERS.md) is
responsible for the contents of this repository.

The rules for merging depend on the type of change in question and its scope of impact.
The rules for merging depend on the type of change in question and its scope of impact. If you
are unsure about the scope of impact for a change, i.e. if a change is trivial or non-trivial,
please ping the Oversight Committee for help.

* Trivial changes may be merged with 1 review from any InstructLab maintainer.
* Examples of trivial changes include minor wording adjustments or typo fixes in
documentation, changes to CI fixes, CI dependency updates, etc.
* Non-trivial changes have more loosely defined requirements. Input should be sought
out from maintainers of relevant components. The broader the scope or more
controversial the change, the more broad the consensus should be required for
merging. The final approval and merge falls to a member of the Oversight Committee.
This final review is to ensure that adequate opportunity and attention has
been given by the affected parties.
merging. The final approval and merge (or action, e.g. deleting a repo)
falls to a member of the Oversight Committee. This final review is to ensure that
adequate opportunity and attention has been given by the affected parties.
* Examples of non-trivial changes include approving proposal for new repositories,
creation of new repositories, changes to organization level GitHub settings, archiving
or deleting repositories, design proposals, etc.
* Any maintainer or oversight committee member may request that a change receive
a full vote from the Oversight Committee. More substantial policy changes or a
proposed new project under InstructLab are examples of when this may be
Expand Down