Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update read me with examples of trivial/non-trivial changes #92

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

lhawthorn
Copy link
Member

@lhawthorn lhawthorn commented Jun 12, 2024

And clarify when action must be taken by an oversight committee member. This PR is meant to address #91

Closes #91

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

  • one spacing fix needed to make the linter happy. You should be able to just accept the suggested edit to fix it

  • one suggested addition to the list of non-trivial examples

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @russellb's comments this LGTM! Thank you for taking this on @lhawthorn!

@hickeyma hickeyma requested a review from russellb July 4, 2024 09:56
Copy link
Member

@hickeyma hickeyma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhawthorn for adding the clarification.

@lhawthorn
Copy link
Member Author

@Mergifyio rebase

lhawthorn and others added 3 commits July 4, 2024 12:04
And clarify when action must be taken by an oversight committee member. This PR is meant to address issue 91.

#91

Signed-off-by: Leslie Hawthorn <[email protected]>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Copy link

mergify bot commented Jul 4, 2024

rebase

✅ Branch has been successfully rebased

@russellb russellb merged commit 88f2461 into main Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Governance section examples less vague
4 participants