Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HERON submod #1325

Closed
wants to merge 4 commits into from

Conversation

PaulTalbot-INL
Copy link
Collaborator


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Reference #1114

What are the significant changes in functionality due to this change request?

Updates HERON submodule through merge of idaholab/HERON#24 (Sept. 24 2020)


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@alfoa
Copy link
Collaborator

alfoa commented Oct 2, 2020

@PaulTalbot-INL ready to be reviewed /merged?

@PaulTalbot-INL
Copy link
Collaborator Author

This was specifically to accelerate the Validator, but there's a couple things coming through right now that would be nice to have in. I'll draft it for now and reopen in a bit.

@PaulTalbot-INL PaulTalbot-INL marked this pull request as draft October 2, 2020 15:37
@alfoa
Copy link
Collaborator

alfoa commented Oct 2, 2020

Okay. Let me know when it is ready
A

@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Oct 2, 2020
9 tasks
@alfoa alfoa closed this in #1329 Oct 3, 2020
@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Oct 15, 2020
9 tasks
@PaulTalbot-INL PaulTalbot-INL deleted the update_submod branch April 8, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants