Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated HERON submodule #1346

Merged
merged 1 commit into from
Oct 16, 2020
Merged

updated HERON submodule #1346

merged 1 commit into from
Oct 16, 2020

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Oct 15, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Continues #1325

What are the significant changes in functionality due to this change request?

Update HERON through the merge of idaholab/HERON#46

Updates to HERON since last update:

  • Added input parsing for Validator, Dispatcher
  • Updated following RAVEN's BasicStatistics update (slight change to percentiles)
  • Added optional Case labels for passing Case information to user Functions
  • API for simple custom per-case dispatching
  • Added multiplier for all ValuedParams in HERON input to scale and/or change sign of results
  • Correctly capture component minimum levels in pyomo dispatcher
  • Allow time-dependent (e.g. ARMA) Capacities and Minimums for components

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Mingw Test on 00194be : invalidated by @joshua-cogliati-inl

fiddled with civet

Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update approved

@alfoa
Copy link
Collaborator

alfoa commented Oct 16, 2020

Checklist passed...

PR can be merged...

Approved...

Merging

@alfoa alfoa merged commit c8cea72 into idaholab:devel Oct 16, 2020
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants