-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use meta.json to request smarter & fix wrong initialization timings of features #717
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
eea6a14
feat: a `hasMeta` function with cache support to check if the meta fi…
tyn1998 54908ca
feat: now features that rely on OD data only run when meta.json exists
tyn1998 3b9250f
refactor: encapsulate the meta related code with the MetaStore class
tyn1998 fe28890
feat: use meta.updatedAt to decide lastDataAvailableMonth
tyn1998 bcf2c47
Merge branch 'master' into feat/use-meta-data
tyn1998 71b1f48
fix: features initialize unexpectedly in the new UI
tyn1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,14 @@ | ||
import { metaStore } from '../api/common'; | ||
|
||
import $ from 'jquery'; | ||
import * as pageDetect from 'github-url-detection'; | ||
|
||
export function getDeveloperName() { | ||
return $('.p-nickname.vcard-username.d-block').text().trim().split(' ')[0]; | ||
} | ||
|
||
export async function isDeveloperWithMeta() { | ||
return ( | ||
pageDetect.isUserProfile() && (await metaStore.has(getDeveloperName())) | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,33 @@ | ||
import { metaStore } from '../api/common'; | ||
|
||
import $ from 'jquery'; | ||
import * as pageDetect from 'github-url-detection'; | ||
import elementReady from 'element-ready'; | ||
|
||
export function getRepoName() { | ||
return pageDetect.utils.getRepositoryInfo(window.location)!.nameWithOwner; | ||
} | ||
|
||
export function hasRepoContainerHeader() { | ||
const headerElement = $('#repository-container-header'); | ||
return headerElement && !headerElement.attr('hidden'); | ||
} | ||
|
||
export async function isRepoRoot() { | ||
return pageDetect.isRepoRoot(); | ||
} | ||
|
||
/** | ||
* check if the repository is public | ||
*/ | ||
export async function isPublicRepo() { | ||
const selector = 'meta[name="octolytics-dimension-repository_public"]'; | ||
await elementReady(selector); | ||
// <meta name="octolytics-dimension-repository_public" content="true/false"> | ||
const isPublic = $(selector).attr('content') === 'true'; | ||
return pageDetect.isRepo() && isPublic; | ||
} | ||
|
||
export async function isPublicRepoWithMeta() { | ||
return (await isPublicRepo()) && (await metaStore.has(getRepoName())); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
const isPerceptor = (): boolean => | ||
window.location.search.includes('?redirect=perceptor'); | ||
const isPerceptor = (): boolean => { | ||
return window.location.search.includes('?redirect=perceptor'); | ||
}; | ||
|
||
export default isPerceptor; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This three checkers will work in both the old and the new UI.