feat: use meta.json to request smarter & fix wrong initialization timings of features #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now they run expectedly in the both old and new UI
tyn1998
force-pushed
the
feat/use-meta-data
branch
from
1ffe41d
to
71b1f48
Compare
tyn1998
commented
Aug 21, 2023
Comment on lines
+10
to
+29
|
|
||
| export function hasRepoContainerHeader() { | ||
| const headerElement = $('#repository-container-header'); | ||
| return headerElement && !headerElement.attr('hidden'); | ||
| } | ||
|
|
||
| export async function isRepoRoot() { | ||
| return pageDetect.isRepoRoot(); | ||
| } | ||
|
|
||
| /** | ||
| * check if the repository is public | ||
| */ | ||
| export async function isPublicRepo() { | ||
| const selector = 'meta[name="octolytics-dimension-repository_public"]'; | ||
| await elementReady(selector); | ||
| // <meta name="octolytics-dimension-repository_public" content="true/false"> | ||
| const isPublic = $(selector).attr('content') === 'true'; | ||
| return pageDetect.isRepo() && isPublic; | ||
| } |
There was a problem hiding this comment.
This three checkers will work in both the old and the new UI.
Comment on lines
-56
to
+64
| (await elementReady('#repository-container-header'))?.append(container); | ||
| (await elementReady('nav.js-repo-nav'))?.append(container); |
There was a problem hiding this comment.
and this selector also works in the both UI.
tyn1998
changed the title
lastDataAvailableMonth
menbotics
bot
added
the
kind/feature
|
/approve |
menbotics
bot
added
the
pull/approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
In this PR, meta.json is introduced to decrease invalid network requests and to decide
lastDataAvailableMonth.meta.json examples:
Checklist
Others