Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor adjustments #1649

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

chore: minor adjustments #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ccfbac
feat: add assets folder to store image locally
argbet21 Oct 30, 2024
a785acb
fix: update HTML to reference local image instead of external URL
argbet21 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added assets/hyperledger_caliper_logo_color.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion packages/caliper-core/lib/manager/report/template/report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
<body style="font-family: IBM Plex Sans; font-weight: 200;">
<main>
<div class="left-column">
<img src="https://hyperledger-caliper.github.io/caliper/assets/img/hyperledger_caliper_logo_color.png" style="width:95%;" alt="">
<img src="/assets/hyperledger_caliper_logo_color.png" style="width:95%;" alt="">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately at the moment I don't think this would work. We need to consider how uses of caliper say via npm modules would work, plus if they publish the report somwhere they would need to be able to get the file from somewhere. Not sure what the best solution is to this at this point.

<ul>
<h3>&nbspBasic information</h3>
{{#summary.meta}}
Expand Down
Loading