chore: minor adjustments #1649
Open
chore: minor adjustments #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Argbet <[email protected]>
Signed-off-by: Argbet <[email protected]>
davidkel
reviewed
Nov 1, 2024
| @@ -122,7 +122,7 @@ | |||
| <body style="font-family: IBM Plex Sans; font-weight: 200;"> | |||
| <main> | |||
| <div class="left-column"> | |||
| <img src="https://hyperledger-caliper.github.io/caliper/assets/img/hyperledger_caliper_logo_color.png" style="width:95%;" alt=""> | |||
| <img src="/assets/hyperledger_caliper_logo_color.png" style="width:95%;" alt=""> | |||
There was a problem hiding this comment.
Unfortunately at the moment I don't think this would work. We need to consider how uses of caliper say via npm modules would work, plus if they publish the report somwhere they would need to be able to get the file from somewhere. Not sure what the best solution is to this at this point.
davidkel
requested changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #1647.
Lmk if this change addresses the issue or if you were thinking of something else.