Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize updateOrConcatWithKey #435

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Optimize updateOrConcatWithKey #435

wants to merge 6 commits into from

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Apr 24, 2022 •
edited
Loading

Fixes #403.

TODO:

@treeowl
Copy link
Collaborator

treeowl commented Apr 24, 2022 •
edited
Loading

Whee! This shrinking stuff is cool. I remain concerned about its implications for the non-moving garbage collector. That adds some code to each shrink for ... some sort of fancy footwork. @bgamari, could you advise on performance implications?

This was referenced Apr 25, 2022
Open
Open
Open
@sjakobi sjakobi force-pushed the sjakobi/403-updateOrConcatWithKey branch from fcab796 to 7617553 Compare April 25, 2022 18:53
@sjakobi sjakobi mentioned this pull request Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updateOrConcatWithKey could be more efficient
2 participants
@sjakobi @treeowl