-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks don't seem to exercise collision handling #439
Labels
Comments
Historically, the view has been that collisions had better be rare enough not to matter much. There's plenty of O(n^2) gunk in collision buckets. |
Yeah, this isn't a high priority task. It's mostly the result of me wanting to try the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have benchmarks with keys of type
Int
,ByteString
andString
. All of these use the instances provided inHashable
which I'd expect not to produce a lot of hash collisions.For tuning the code that handles collisions, e.g. #435, it would be useful to have a key type that is more collision-prone.
The text was updated successfully, but these errors were encountered: