Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): ember-composable-helpers -> @nullvoxpopuli/ember-composable-helpers #2493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(components): ember-composable-helpers -> @nullvoxpopuli/ember-composable-helpers #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-shirts-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": patch
---

swap unmaintained `ember-composable-helpers` -> `@nullvoxpopuli/ember-composable-helpers` - this package is no longer maintained
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
"@floating-ui/dom": "^1.6.3",
"@hashicorp/design-system-tokens": "^2.2.1",
"@hashicorp/flight-icons": "^3.6.0",
"@nullvoxpopuli/ember-composable-helpers": "^5.2.5",
"decorator-transforms": "^1.1.0",
"ember-a11y-refocus": "^4.1.3",
"ember-cli-sass": "^11.0.1",
"ember-composable-helpers": "^5.0.0",
"ember-element-helper": "^0.8.5",
"ember-focus-trap": "^1.1.0",
"ember-get-config": "^2.1.1",
Expand Down
4 changes: 2 additions & 2 deletions website/docs/components/table/partials/code/how-to-use.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ For clarity, there are a couple of important points to note here:

!!! Info

This component takes advantage of the `sort-by` helper provided by [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers).
This component takes advantage of the `sort-by` helper provided by [@nullvoxpopuli/ember-composable-helpers](https://github.com/NullVoxPopuli/ember-composable-helpers).

!!!

Expand Down Expand Up @@ -311,7 +311,7 @@ In the `<:head>` the `setSortBy` function is invoked when the `<ThSort>` element

In the `<:body>` the values of `sortBy` and `sortOrder` are provided instead as arguments to a consumer-side function that takes care of custom sorting the model/data.

_Notice: in this case for the example we're using the [`call` helper](https://github.com/DockYard/ember-composable-helpers#call) from [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers)._
_Notice: in this case for the example we're using the [`call` helper](https://github.com/NullVoxPopuli/ember-composable-helpers?tab=readme-ov-file#call) from [@nullvoxpopuli/ember-composable-helpers](https://github.com/NullVoxPopuli/ember-composable-helpers)._

The sorting function in the backing class code will look something like this (the actual implementation will depend on the consumer-side/business-logic context):

Expand Down
58 changes: 23 additions & 35 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/core@npm:>=7.2.2, @babel/core@npm:^7.0.0, @babel/core@npm:^7.1.6, @babel/core@npm:^7.11.6, @babel/core@npm:^7.12.0, @babel/core@npm:^7.12.3, @babel/core@npm:^7.13.10, @babel/core@npm:^7.14.5, @babel/core@npm:^7.16.10, @babel/core@npm:^7.16.7, @babel/core@npm:^7.24.5, @babel/core@npm:^7.3.4":
"@babel/core@npm:>=7.2.2, @babel/core@npm:^7.1.6, @babel/core@npm:^7.11.6, @babel/core@npm:^7.12.0, @babel/core@npm:^7.12.3, @babel/core@npm:^7.13.10, @babel/core@npm:^7.14.5, @babel/core@npm:^7.16.10, @babel/core@npm:^7.16.7, @babel/core@npm:^7.24.5, @babel/core@npm:^7.3.4":
version: 7.24.5
resolution: "@babel/core@npm:7.24.5"
dependencies:
Expand Down Expand Up @@ -3381,6 +3381,18 @@ __metadata:
languageName: node
linkType: hard

"@embroider/addon-shim@npm:^1.8.8":
version: 1.8.9
resolution: "@embroider/addon-shim@npm:1.8.9"
dependencies:
"@embroider/shared-internals": "npm:^2.6.0"
broccoli-funnel: "npm:^3.0.8"
common-ancestor-path: "npm:^1.0.1"
semver: "npm:^7.3.8"
checksum: 10/c49c85e8035b740958db5bb4117c44789f01315da34b686cfe78bde518bdf77028a41970a5618bff1650b8167a8cae2bc8cb4bf278e5505b74d35e0262366c4f
languageName: node
linkType: hard

"@embroider/core@npm:^3.4.7":
version: 3.4.9
resolution: "@embroider/core@npm:3.4.9"
Expand Down Expand Up @@ -4272,6 +4284,7 @@ __metadata:
"@glint/template": "npm:^1.4.0"
"@hashicorp/design-system-tokens": "npm:^2.2.1"
"@hashicorp/flight-icons": "npm:^3.6.0"
"@nullvoxpopuli/ember-composable-helpers": "npm:^5.2.5"
"@rollup/plugin-babel": "npm:^6.0.4"
"@tsconfig/ember": "npm:^3.0.8"
"@types/ember-qunit": "npm:^6.1.1"
Expand All @@ -4288,7 +4301,6 @@ __metadata:
ember-a11y-refocus: "npm:^4.1.3"
ember-basic-dropdown: "npm:^8.1.0"
ember-cli-sass: "npm:^11.0.1"
ember-composable-helpers: "npm:^5.0.0"
ember-concurrency: "npm:^4.0.2"
ember-element-helper: "npm:^0.8.5"
ember-focus-trap: "npm:^1.1.0"
Expand Down Expand Up @@ -4945,6 +4957,15 @@ __metadata:
languageName: node
linkType: hard

"@nullvoxpopuli/ember-composable-helpers@npm:^5.2.5":
version: 5.2.5
resolution: "@nullvoxpopuli/ember-composable-helpers@npm:5.2.5"
dependencies:
"@embroider/addon-shim": "npm:^1.8.8"
checksum: 10/26f2a1f45701813e1ab42b9024e45a40cb9aa179bedcda46580750abb2840a502eacf7df082744545508e80458954902411e25cbad131b672971378bc00f46e5
languageName: node
linkType: hard

"@percy/cli-app@npm:1.28.8":
version: 1.28.8
resolution: "@percy/cli-app@npm:1.28.8"
Expand Down Expand Up @@ -9199,27 +9220,6 @@ __metadata:
languageName: node
linkType: hard

"broccoli-funnel@npm:2.0.1":
version: 2.0.1
resolution: "broccoli-funnel@npm:2.0.1"
dependencies:
array-equal: "npm:^1.0.0"
blank-object: "npm:^1.0.1"
broccoli-plugin: "npm:^1.3.0"
debug: "npm:^2.2.0"
fast-ordered-set: "npm:^1.0.0"
fs-tree-diff: "npm:^0.5.3"
heimdalljs: "npm:^0.2.0"
minimatch: "npm:^3.0.0"
mkdirp: "npm:^0.5.0"
path-posix: "npm:^1.0.0"
rimraf: "npm:^2.4.3"
symlink-or-copy: "npm:^1.0.0"
walk-sync: "npm:^0.3.1"
checksum: 10/805c19b2def505076851ed998097acd4667c54affbcd25983415218d5ae09905abfd6f3b9d0da338ac9e8a45d89e89345c54f6aabed12539b00a41de5608a9c5
languageName: node
linkType: hard

"broccoli-funnel@npm:^1.0.1":
version: 1.2.0
resolution: "broccoli-funnel@npm:1.2.0"
Expand Down Expand Up @@ -13160,18 +13160,6 @@ __metadata:
languageName: node
linkType: hard

"ember-composable-helpers@npm:^5.0.0":
version: 5.0.0
resolution: "ember-composable-helpers@npm:5.0.0"
dependencies:
"@babel/core": "npm:^7.0.0"
broccoli-funnel: "npm:2.0.1"
ember-cli-babel: "npm:^7.26.3"
resolve: "npm:^1.10.0"
checksum: 10/d236f250771bc290c820c78990c590abcaed361fe35ad75e1f68b8aa3660f9e4d24e1954b9b1a3e98b0301ab8d1fcd0da862f217b857ba87494f38f5b1472c11
languageName: node
linkType: hard

"ember-concurrency@npm:^4.0.2":
version: 4.0.2
resolution: "ember-concurrency@npm:4.0.2"
Expand Down