-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): ember-composable-helpers
-> @nullvoxpopuli/ember-composable-helpers
#2493
base: main
Are you sure you want to change the base?
Conversation
…composable-helpers`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change also resolve issue with embroider-vite builds
hey! would you be able to link to somewhere we can see/read about the issue?
I can provide the answer: the new version of the addon makes it a v2 addon, which means it can be used with embroider-vite builds. A few of the improvements include: v2, ts, glint registry for loose mode, general bugfixes. |
right, thanks for the background, Melanie! I'm not opposing this change if that's where the future of this addon lies, but we'll have to bear in mind that our consumers are still using |
@alex-ju good point, let's drive a horizontal initiative to change that. I don't think it will be too difficult to convince the rest of the teams. |
the README for But it is certainly not great to provide two copies of basically the same thing. deduping via the instructions here is the best folks can do until all addons have rid themselves the old addon entirely (and the usefulness in general is much less with gjs/gts anyway) |
📌 Summary
ember-composable-helpers
is no longer maintained and has a number of issues that is now fixed in actively@nullvoxpopuli/ember-composable-helpers
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.