Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): ember-composable-helpers -> @nullvoxpopuli/ember-composable-helpers #2493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Oct 11, 2024

📌 Summary

  • ember-composable-helpers is no longer maintained and has a number of issues that is now fixed in actively @nullvoxpopuli/ember-composable-helpers
  • this change also resolve issue with embroider-vite builds
  • new pacakge has fully typed helpers which would help with gts migration at some point

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Oct 11, 2024 5:35am
hds-website ✅ Ready (Inspect) Visit Preview Oct 11, 2024 5:35am

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change also resolve issue with embroider-vite builds

hey! would you be able to link to somewhere we can see/read about the issue?

@MelSumner
Copy link
Contributor

this change also resolve issue with embroider-vite builds

hey! would you be able to link to somewhere we can see/read about the issue?

I can provide the answer: the new version of the addon makes it a v2 addon, which means it can be used with embroider-vite builds. A few of the improvements include: v2, ts, glint registry for loose mode, general bugfixes.

@alex-ju
Copy link
Member

alex-ju commented Oct 25, 2024

right, thanks for the background, Melanie! I'm not opposing this change if that's where the future of this addon lies, but we'll have to bear in mind that our consumers are still using ember-composable-helpers

@MelSumner
Copy link
Contributor

@alex-ju good point, let's drive a horizontal initiative to change that. I don't think it will be too difficult to convince the rest of the teams.

@NullVoxPopuli
Copy link

NullVoxPopuli commented Oct 25, 2024

our consumers are still using ember-composable-helpers

the README for @nullvoxpopuli/ember-composable-helpers has instructions for how to force all copy of ember-composable-helpers to use the new v2 addon.

But it is certainly not great to provide two copies of basically the same thing.
the original ember-composable-helpers should not be used in any new project, but resolving this will take some time.

deduping via the instructions here is the best folks can do until all addons have rid themselves the old addon entirely (and the usefulness in general is much less with gjs/gts anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants