-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: gossip module names and extract FallenBehindManager to gossip module #16113
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Mustafa Uzun <[email protected]>
Signed-off-by: Mustafa Uzun <[email protected]>
Signed-off-by: Mustafa Uzun <[email protected]>
Signed-off-by: Mustafa Uzun <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16113 +/- ##
=============================================
- Coverage 57.89% 57.89% -0.01%
- Complexity 19676 19677 +1
=============================================
Files 2719 2719
Lines 99447 99447
Branches 10285 10285
=============================================
- Hits 57576 57572 -4
- Misses 38278 38288 +10
+ Partials 3593 3587 -6
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the changes generally, but I fear the file movement will still be in substantial conflict with this open PR
Since we decided to split that huge PR into multiple smaller pieces, I think this is no longer a blocker. |
Description:
Related issue(s):
Fixes #16105
Notes for reviewer:
Checklist