Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gossip module names and extract FallenBehindManager to gossip module #16113

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mustafauzunn
Copy link
Collaborator

@mustafauzunn mustafauzunn commented Oct 23, 2024

Description:

  1. Rename gossip modules to org.hiero.consensus.gossip...
  2. Move FallenBehindManager to gossip module

Related issue(s):

Fixes #16105

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mustafauzunn mustafauzunn added Platform Modularization Tickets pertaining to platform module organization Platform Tickets pertaining to the platform labels Oct 23, 2024
@mustafauzunn mustafauzunn self-assigned this Oct 23, 2024
@mustafauzunn mustafauzunn added this to the v0.56 milestone Oct 23, 2024
@mustafauzunn mustafauzunn reopened this Oct 23, 2024
Signed-off-by: Mustafa Uzun <[email protected]>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.89%. Comparing base (f1c9cf6) to head (0a0c578).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16113      +/-   ##
=============================================
- Coverage      57.89%   57.89%   -0.01%     
- Complexity     19676    19677       +1     
=============================================
  Files           2719     2719              
  Lines          99447    99447              
  Branches       10285    10285              
=============================================
- Hits           57576    57572       -4     
- Misses         38278    38288      +10     
+ Partials        3593     3587       -6     
Files with missing lines Coverage Δ
...irlds/platform/gossip/FallenBehindManagerImpl.java 78.04% <ø> (ø)
...rm/gossip/shadowgraph/ShadowgraphSynchronizer.java 0.81% <ø> (ø)
.../swirlds/platform/gossip/sync/SyncManagerImpl.java 83.33% <ø> (ø)
...ds/platform/gossip/sync/protocol/SyncProtocol.java 95.00% <ø> (ø)
...orm/network/protocol/ReconnectProtocolFactory.java 100.00% <ø> (ø)
...platform/network/protocol/SyncProtocolFactory.java 100.00% <ø> (ø)
.../swirlds/platform/reconnect/ReconnectProtocol.java 81.63% <ø> (ø)

... and 7 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f1c9cf6) 99264 61032 61.48%
Head commit (0a0c578) 99264 (+0) 61022 (-10) 61.47% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16113) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@litt3 litt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the changes generally, but I fear the file movement will still be in substantial conflict with this open PR

@anthony-swirldslabs
Copy link
Contributor

I approve of the changes generally, but I fear the file movement will still be in substantial conflict with this open PR

Since we decided to split that huge PR into multiple smaller pieces, I think this is no longer a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Modularization Tickets pertaining to platform module organization Platform Tickets pertaining to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor gossip modules
4 participants