Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanless ast #907

Merged
merged 3 commits into from
Jul 22, 2023
Merged

spanless ast #907

merged 3 commits into from
Jul 22, 2023

Conversation

feds01
Copy link
Contributor

@feds01 feds01 commented Jul 21, 2023

  • ast: Make AST spanless, and store Spans within SPAN_MAP
  • ast: Use RwLock and once_cell:sync::Lazy for SpanMap

@feds01 feds01 self-assigned this Jul 21, 2023
@feds01 feds01 force-pushed the spanless-ast branch 2 times, most recently from cbad628 to 804eb2a Compare July 21, 2023 20:49
@feds01 feds01 mentioned this pull request Jul 21, 2023
Merged
1 task
@feds01 feds01 added the ast Relating to AST label Jul 21, 2023
kontheocharis
kontheocharis previously approved these changes Jul 22, 2023
View reviewed changes
compiler/hash-ast/src/ast.rs Outdated Show resolved Hide resolved
@feds01 feds01 merged commit 165f531 into main Jul 22, 2023
1 check passed
@feds01 feds01 deleted the spanless-ast branch July 22, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kontheocharis kontheocharis kontheocharis approved these changes

Assignees

@feds01 feds01

Labels
ast Relating to AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feds01 @kontheocharis