core: Use `SourceLocation` (new name `Span`) over `Span` (new name `ByteRange`) to refer to locations #909

feds01 · 2023-07-21T22:44:29Z

ast: Make AST spanless, and store Spans within SPAN_MAP
ast: Use RwLock and once_cell:sync::Lazy for SpanMap
lower: fix panic when trying to access numbered ADT fields
ast: Add AstNodeId to AstNodes, guaranteeing node lists have spans
ast+source: use SourceLocation over Span
ir+lower: switch to using AstNodeIds for spans instead of directly using spans
ir: add static size assertions
source: rename RowColSpan to RowColRange
source: rename Span to ByteRange
source: rename SourceLocation to Span
tir: allow AstInfo to have multiple items refer to the same AstNodeId

Todo:

review & merge spanless ast #907

…using spans

…eId` This meant that `AstMap` couldn't use `BiMap` because it doesn't support insertions into only a single side of the map. To solve this, `AstMapInner` was introduced.

compiler/hash-ir/src/ir.rs

compiler/hash-lexer/src/lib.rs

feds01 self-assigned this Jul 21, 2023

feds01 requested a review from kontheocharis July 21, 2023 22:44

feds01 added the core Relating to the core internals of the compiler. label Jul 21, 2023

feds01 changed the title ~~core: Use SourceLocation (new name Span) over Span to refer to locations~~ core: Use SourceLocation (new name Span) over Span (new name ByteRange) to refer to locations Jul 21, 2023

feds01 force-pushed the source-location-to-span branch from a156cc4 to d5a3ba9 Compare July 22, 2023 13:44

feds01 added 8 commits July 22, 2023 09:46

ast: Add AstNodeId to AstNodes, guaranteeing node lists have spans

ddfbf89

ast+source: use SourceLocation over Span

9de8a71

ir+lower: switch to using AstNodeIds for spans instead of directly …

f3344f0

…using spans

ir: add static size assertions

687c680

source: rename RowColSpan to RowColRange

73b9025

source: rename Span to ByteRange

cf415f2

source: rename SourceLocation to Span

9867a39

tir: allow AstInfo to have multiple items refer to the same `AstNod…

d372d9e

…eId` This meant that `AstMap` couldn't use `BiMap` because it doesn't support insertions into only a single side of the map. To solve this, `AstMapInner` was introduced.

feds01 force-pushed the source-location-to-span branch from d5a3ba9 to d372d9e Compare July 22, 2023 13:46

kontheocharis reviewed Jul 22, 2023

View reviewed changes

compiler/hash-ir/src/ir.rs Outdated Show resolved Hide resolved

compiler/hash-lexer/src/lib.rs Show resolved Hide resolved

ir: rename span fields to origin and other cleanups

85115fe

feds01 requested a review from kontheocharis July 22, 2023 14:09

kontheocharis reviewed Jul 22, 2023

View reviewed changes

compiler/hash-lexer/src/lib.rs Show resolved Hide resolved

kontheocharis approved these changes Jul 22, 2023

View reviewed changes

feds01 merged commit 5f3af9e into main Jul 22, 2023
1 check passed

feds01 deleted the source-location-to-span branch July 22, 2023 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: Use `SourceLocation` (new name `Span`) over `Span` (new name `ByteRange`) to refer to locations #909

core: Use `SourceLocation` (new name `Span`) over `Span` (new name `ByteRange`) to refer to locations #909

feds01 commented Jul 21, 2023 •

edited

Loading

core: Use SourceLocation (new name Span) over Span (new name ByteRange) to refer to locations #909

core: Use SourceLocation (new name Span) over Span (new name ByteRange) to refer to locations #909

Conversation

feds01 commented Jul 21, 2023 • edited Loading

core: Use `SourceLocation` (new name `Span`) over `Span` (new name `ByteRange`) to refer to locations #909

core: Use `SourceLocation` (new name `Span`) over `Span` (new name `ByteRange`) to refer to locations #909

feds01 commented Jul 21, 2023 •

edited

Loading