Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest storybook #106

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Upgrade to latest storybook #106

merged 9 commits into from
Jan 11, 2024

Commits on Jan 11, 2024

  1. Upgrade to latest storybook 

    To make sure that the plugin works with the most recent Storybook
version, I'm upgrading dev dependencies.

As part of this I'm attempting to fix
#104, applying the
changes (different imports in addons.js and decorator.js) suggested
there.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b80f4be View commit details
    Browse the repository at this point in the history

  2. Upgrade to latest yarn 

    I ran into an issue when building the Storybook and they suggested using
the latest yarn: storybookjs/storybook#22431 (comment)
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e3282b9 View commit details
    Browse the repository at this point in the history

  3. Use yarn 4 in github actions 

    The project no longer builds with v1
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c368534 View commit details
    Browse the repository at this point in the history

  4. Add @babel/preset-react dependency

    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    dd2fc9a View commit details
    Browse the repository at this point in the history

  5. Drop support for Storybook v5 

    Version 6 was released almost four years ago. It's starting to be
hard to test this old version, and to stay leaner when moving forward
I've decided to drop support for Storybook v5 at this point.

We can still maintain a v5 branch if the need for it arises. But
starting with the next release, users can't expect to be able to use
happo-plugin-storybook with Storybook <v6.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    192a1a3 View commit details
    Browse the repository at this point in the history

  6. Remove yarn list from github actions script 

    This command is no longer supported in v4 of yarn. We use it for
debugging purposes but it isn't strictly needed.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    37e2e60 View commit details
    Browse the repository at this point in the history

  7. Attempt to fix Storybook v6 build 

    The difference between v7 and v6 is starting to be quite large at this
point.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5e2284d View commit details
    Browse the repository at this point in the history

  8. Improve the check for Storybook version 

    I ran into an issue with yarn not supporting `yarn list` anymore. To fix
this, I'm adding yet another way of detection -- this time reading the
package.json file to look for the version among the installed packages.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ec3af39 View commit details
    Browse the repository at this point in the history

  9. Attempt to fix Storybook 6 build again 

    Continuing the work to make the v6 build work.
    @trotzig
    trotzig committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    999320e View commit details
    Browse the repository at this point in the history