Upgrade to latest storybook #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure that the plugin works with the most recent Storybook version, I'm upgrading dev dependencies. As part of this I'm attempting to fix #104, applying the changes (different imports in addons.js and decorator.js) suggested there.
trotzig
force-pushed
the
storybook-latest
branch
from
3f308dc
to
b80f4be
Compare
I ran into an issue when building the Storybook and they suggested using the latest yarn: storybookjs/storybook#22431 (comment)
trotzig
force-pushed
the
storybook-latest
branch
3 times, most recently
from
458ad2b
to
4612660
Compare
The project no longer builds with v1
trotzig
force-pushed
the
storybook-latest
branch
from
4612660
to
c368534
Compare
Version 6 was released almost four years ago. It's starting to be hard to test this old version, and to stay leaner when moving forward I've decided to drop support for Storybook v5 at this point. We can still maintain a v5 branch if the need for it arises. But starting with the next release, users can't expect to be able to use happo-plugin-storybook with Storybook <v6.
This command is no longer supported in v4 of yarn. We use it for debugging purposes but it isn't strictly needed.
trotzig
force-pushed
the
storybook-latest
branch
6 times, most recently
from
e2448ea
to
6dc5467
Compare
The difference between v7 and v6 is starting to be quite large at this point.
trotzig
force-pushed
the
storybook-latest
branch
from
6dc5467
to
5e2284d
Compare
I ran into an issue with yarn not supporting `yarn list` anymore. To fix this, I'm adding yet another way of detection -- this time reading the package.json file to look for the version among the installed packages.
trotzig
force-pushed
the
storybook-latest
branch
2 times, most recently
from
f2d7a93
to
b660b5f
Compare
Continuing the work to make the v6 build work.
trotzig
force-pushed
the
storybook-latest
branch
from
b660b5f
to
999320e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that the plugin works with the most recent Storybook version, I'm upgrading dev dependencies.
As part of this I'm attempting to fix
#104, applying the changes (different imports in addons.js and decorator.js) suggested there.