Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GraphQL 3.0.0 #55

Closed
wants to merge 4 commits into from
Closed

Conversation

sungam3r
Copy link
Member

draft for #54:

  • new nuget source
  • drop support for net45/netstandard1.3 - netstandard2.0 only
  • move to latest GraphQL preview
  • netcoreapp2.0 -> netcoreapp2.2
  • update dependencies
  • fix xUnit warnings

- new nuget source
- drop support for net45/netstandard1.3 - netstandard2.0 only
- move to latest GraphQL preview
- netcoreapp2.0 -> netcoreapp2.2
- update dependencies
- fix xUnit warnings
@jquense
Copy link
Collaborator

jquense commented Aug 15, 2019

looks great! I've added you as a collaborator as well. If you like nuget publishing rights i can invite you to the org

@sungam3r
Copy link
Member Author

Thanks!

@rkotenko
Copy link

Could I have an update on when this is going to be merged into master? The 3.0.0 release of Graphql has had numerous preview releases and I would like to use it and this package.

@sungam3r
Copy link
Member Author

I decided to postpone the merge until I figure out what Relay is. When I made edits, I did it without much knowledge about the essence of technology. May be a little later.

@Yakimych
Copy link

Yakimych commented Nov 10, 2019

@sungam3r Wow, very nice cleanup! Looks like you've fixed the "obsolete" warnings too. Thanks for putting the time and effort into this!

I can help test this during the week. Is there any way we can get this up as a "preview" NuGet package or something?

Also wondering whether this will still work with .NET Framework 4.8 (unfortunately we're stuck with it for a while on a large project).

@sungam3r
Copy link
Member Author

Also wondering whether this will still work with .NET Framework 4.8

Everything should work since GraphQL.Relay.csproj targets netstandard2.0.

@MargaretKrutikova
Copy link

We are considering using GraphQL with relay at work and would be very much interested in testing this package. Is it possible to publish a pre-release version so that we could test it out? Thanks a lot! 😃

@sungam3r
Copy link
Member Author

Is it possible to publish a pre-release version so that we could test it out?

I don’t see that CI generating an artifact on the AppVeyor page. Means that I need to investigate how to configure CI. Unfortunately now I do not have time for this. PRs are welcome.

@Yakimych
Copy link

The warning from the logs says
warning MSB4078: The project file "src\GraphQL.Relay\GraphQL.Relay.csproj" is not supported by MSBuild and cannot be built.
I am guessing an older version of MSBuild is being used on AppVeyor, but I can't see any build configuration in the repo.

@sungam3r @jquense I would be happy to look into this further, but I am guessing I don't have permissions to see the settings on AppVeyor?

@Shane32
Copy link
Member

Shane32 commented Apr 28, 2021

@sungam3r Do you want to leave this issue open? I've looked through the code changes. There's some cleanup (e.g. remove excess usings) that probably isn't done yet, but everything of substance has been completed already. It would certainly be more work to merge changes than redo the changes. I suggest leaving a note within issue #86 to also review changes within this PR, then close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants