-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL 4.0.0 Bump. Project clean up. #80
Conversation
…aphql.Relay.StarWars to .net5.0 and graphql-dotnet 4.0.2.
This is a big step in the right direction; thanks @JoeHartzell ! Once the "TODO: Test this" comment has been resolved, I would approve this. I think the project still has a lot more cleanup to do before it is ready for another release. |
Alright. I will look into adding a test for that. In the little bit of testing I did, it seems to work. I just didn't get to verifying it with a test case. I did see quite a bit more to clean up around documentation, example projects, etc... If you have a roadmap/issues that need resolved I would be more than happy to help. I was trying really hard to just keep this focused on the .net/graphql version updates. 😂 |
Co-authored-by: Shane Krueger <[email protected]>
Relates to #55 |
Yes, much easier to review multiple smaller PRs than one large one! The next step (separate PR) is probably stripping away all the bits of the library that don’t relate to Relay and/or have other better implementations, such as deleting the Http namespace in favor of the server project. (I see you’ve already converted the sample projects to use the server project 👍 .) |
Alright I wrote a few test cases for the remaining TODO. Turns out that the method I used was incorrect, should be corrected now. |
…tead of by object
No. I need to review both independently. |
Co-authored-by: Shane Krueger <[email protected]>
Alright I think this is good to go. I'm not sure why this is conflicting? Those conflicts should have been resolved at commit b3ad664. The conflict showed up after accepting the suggestion change to the .net targeting. There is nothing for me to merge from the upstream (GraphQL.Relay master) branch. |
Switch to the upstream branch and pull it, and then switch back to your branch and merge from master, then push the merge commit. I think @sungam3r pulled in some dependabot changes within the last 24 hours which caused the conflict. |
If you don't have the upstream master branch pulled, then you need to "fetch" the upstream repo so that when you try to merge, it will see the new commits. |
Merge this JoeHartzell#1 and it will fix the PR @JoeHartzell |
Btw, since your branch is named |
Fix merge conflict
Alright thanks for the clarification there! |
I would like to review this before merge when I have time. |
@sungam3r If you have time, that would be great! This isn't the end-all of cleanup required for this repo before we release another version, so if you are busy, then we should merge it based on my review. We can certainly wait a bit though. |
@sungam3r I have reviewed this PR and am going to merge this to keep development moving on this repo. Mostly this is just cleanup and transition from 2.4.0 anyway. |
@sungam3r I've merged this PR. Please make comments when/if you have time to do so, and we can address them in a separate PR. |
This is the first meaningful commit to this repo in almost 3 years. 🥇 |
using GraphQL.Server; | ||
using GraphQL.Types; | ||
using GraphQL.Types.Relay; | ||
using GraphQL.Relay.Types; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add empty line after using.
@@ -19,7 +19,7 @@ public void Message_WhenMessageIsProvidedInCtor_ReturnsPassedMessage() | |||
var ex = new IncompleteSliceException("Test"); | |||
Assert.Equal("Test", ex.Message); | |||
ex = new IncompleteSliceException("Test", "paramName"); | |||
Assert.StartsWith($"Test{Environment.NewLine}", ex.Message); | |||
Assert.StartsWith($"Test", ex.Message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove $
@@ -32,7 +32,7 @@ public void InnerException_WhenInnerExceptionIsPassedToCtor_ReturnsPassedExcepti | |||
Assert.Equal(inner, ex.InnerException); | |||
|
|||
ex = new IncompleteSliceException("Test", "paramName", inner); | |||
Assert.StartsWith($"Test{Environment.NewLine}", ex.Message); | |||
Assert.StartsWith($"Test", ex.Message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove $
@@ -0,0 +1,119 @@ | |||
namespace GraphQL.Relay.Test.Types | |||
{ | |||
using System.Linq; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move usings outside the namespace.
{ | ||
public string Id { get; set; } | ||
|
||
public static IEnumerable<SimpleData> GetData() => new List<SimpleData> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
on new line
public override SimpleData GetById(string id) => SimpleData | ||
.GetData() | ||
.FirstOrDefault(x => x.Id.Equals(id)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty line
|
||
public class SimpleSchema : Schema | ||
{ | ||
public SimpleSchema() => (Query) = (new QueryGraphType()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public SimpleSchema() => (Query) = (new QueryGraphType());
->
public SimpleSchema() => Query = new QueryGraphType();
{ | ||
public TodoMutation(): base() { | ||
public TodoMutation() : base() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public TodoMutation() : base()
-> public TodoMutation()
|
I think @Shane32 might have addressed some of these. As most of these are "linting" errors, do you think it would make sense to add an .editorconfig file to the project? Could probably just bring the one over from graphql-dotnet just to keep things consistent? |
Yes |
As an option we may pull editorconfig from main repo into this repo root when building on ci. |
This includes a bump to the GraphQL version for 4.0.0. It also includes cleaning up the example projects. This would include
GraphQL.Relay.StarWars
GraphQL.Relay
GraphQL.Relay.Todo
GraphQL.Relay.Test
Would resolve a few open issues. #79, #54