Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats uploading #4226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix stats uploading #4226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c40f980
Fix stats uploading
jonathanmetzman Sep 12, 2024
a93c121
Merge branch 'master' into jobrun
jonathanmetzman Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,10 +859,10 @@ def postprocess_process_crashes(uworker_input: uworker_msg_pb2.Input,
# Artificial delay to throttle appengine updates.
time.sleep(1)

# TODO(metzman): Replace fuzz_task_output.fully_qualified_fuzzer_name` with
# `fuzz_task_input.fuzz_target` instead.
upload_job_run_stats(fuzz_task_output.fully_qualified_fuzzer_name,
uworker_input.job_type, fuzz_task_output.crash_revision,
# If there is no fuzz_target, this will be None.
stats_fuzzer_name = fuzz_target or fully_qualified_fuzzer_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think the original problem was that somehow these lines above didn't work:

if uworker_input.fuzz_task_input.HasField('fuzz_target'):
    fuzz_target = uworker_io.entity_from_protobuf(
        uworker_input.fuzz_task_input.fuzz_target, data_types.FuzzTarget)
    fully_qualified_fuzzer_name = fuzz_target.fully_qualified_name()

Leading to fully_qualified_fuzzer_name defaulting to the engine name.

upload_job_run_stats(stats_fuzzer_name, uworker_input.job_type,
fuzz_task_output.crash_revision,
fuzz_task_output.job_run_timestamp, new_crash_count,
known_crash_count, fuzz_task_output.testcases_executed,
crash_groups_for_stats)
Expand Down
Loading