Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats uploading #4226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix stats uploading #4226

wants to merge 2 commits into from

Conversation

jonathanmetzman
Copy link
Collaborator

Fixes: #4217

oliverchang
oliverchang reviewed Sep 13, 2024
View reviewed changes
src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py
upload_job_run_stats(fuzz_task_output.fully_qualified_fuzzer_name,
uworker_input.job_type, fuzz_task_output.crash_revision,
# If there is no fuzz_target, this will be None.
stats_fuzzer_name = fuzz_target or fully_qualified_fuzzer_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think the original problem was that somehow these lines above didn't work:

if uworker_input.fuzz_task_input.HasField('fuzz_target'):
    fuzz_target = uworker_io.entity_from_protobuf(
        uworker_input.fuzz_task_input.fuzz_target, data_types.FuzzTarget)
    fully_qualified_fuzzer_name = fuzz_target.fully_qualified_name()

Leading to fully_qualified_fuzzer_name defaulting to the engine name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JobRun not being saved with the fully qualified fuzz_target name.
2 participants
@jonathanmetzman @oliverchang