Add sanity checks for passed in options and initializers to GIDVerifyAccountDetail. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
requested changes
Apr 30, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
mdmathias
requested changes
May 3, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
…st strict mocks to less restrictive. Also, fix nullability warnings in GIDFakeMainBundle.
mdmathias
requested changes
May 8, 2024
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
… pass a configuration.
mdmathias
requested changes
May 10, 2024
mdmathias
requested changes
May 13, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
This was referenced May 13, 2024
mdmathias
approved these changes
May 13, 2024
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin implementing
-[GIDVerifyAccountDetail verifyAccountDetailsInteractivelyWithOptions:]starting with input validation to ensure that the client has passed in valid parameters, provided a valid presenting view controller, and defined the proper callback schemes. Additionally, add tests forGIDVerifyAccountDetaillike ensuring that a configuration was set which will be covered by the created initializers.