Start the incremental authorization flow by creating OIDAuthorizationRequest.
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resentAuthorizationRequest
mdmathias
requested changes
May 7, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
…st strict mocks to less restrictive. Also, fix nullability warnings in GIDFakeMainBundle.
mdmathias
reviewed
May 10, 2024
… pass a configuration.
… sign-in and verify flow.
…resentAuthorizationRequest
mdmathias
requested changes
May 13, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
Base automatically changed from
briannamorales/optionsValidation
to
briannamorales/vwg-flow
May 14, 2024 00:30
mdmathias
requested changes
May 15, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
mdmathias
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once verifying that the client has passed in valid parameters, provided a valid presenting view controller, and defined proper callback schemes, then an instance of
OIDAuthorizationRequestis made to start the incremental authorization flow. This is done similar to the interactive sign in flow. Testing will be done in a future PR once the response has been handled.