Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(trace) remove test skip and stop mocking console error #80158

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
61e9985
test(trace) remove test skip and stop mocking console error
JonasBa Nov 1, 2024
b2330de
flake fix attempt
JonasBa Nov 2, 2024
0e61f3e
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 2, 2024
3badbf8
flake fix attempt
JonasBa Nov 2, 2024
8fd9ec2
flake fix attempt
JonasBa Nov 2, 2024
eae514b
add search input assertion test
JonasBa Nov 2, 2024
ad708c7
test
JonasBa Nov 3, 2024
f455d61
test
JonasBa Nov 3, 2024
f1ac39f
test disabling this effect
JonasBa Nov 3, 2024
1763f9b
test
JonasBa Nov 3, 2024
ae5a44a
test
JonasBa Nov 3, 2024
5dd9788
test
JonasBa Nov 3, 2024
9b8aa6f
reenable input effect
JonasBa Nov 4, 2024
f460a07
await everything
JonasBa Nov 4, 2024
3e63a1c
await everything
JonasBa Nov 4, 2024
5cd85b5
skip search for now
JonasBa Nov 4, 2024
1d64a1a
revert onchange
JonasBa Nov 4, 2024
020a71f
test fix
JonasBa Nov 4, 2024
e5aec18
test fix
JonasBa Nov 4, 2024
b28ba35
test fix
JonasBa Nov 4, 2024
c37ef9a
test fix
JonasBa Nov 4, 2024
02fd70a
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
96a5ff1
test timeout
JonasBa Nov 5, 2024
21142f9
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
dc49532
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
3de50d1
test live query
JonasBa Nov 5, 2024
c3c324e
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
3ee8c6d
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
87761fc
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
0c7e4ef
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
693f6db
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
1fa4a45
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
76360a8
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
d26af67
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 5, 2024
f44e647
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
f69ee38
test waitfor
JonasBa Nov 6, 2024
1722873
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
09720f5
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
855cc77
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
3812f04
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
b47300f
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
937ee52
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
6ad3f5e
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
8852234
Merge branch 'master' into jb/trace/flakes
JonasBa Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/utils/useDispatchingReducer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,12 @@ export function useDispatchingReducer<R extends React.Reducer<any, any>>(
// we are likely going to have to rethrow async and lose stack traces...
actionQueue.current.push(a);

if (updatesRef.current !== null) {
if (updatesRef.current) {
window.cancelAnimationFrame(updatesRef.current);
updatesRef.current = null;
}

window.requestAnimationFrame(() => {
updatesRef.current = window.requestAnimationFrame(() => {
setState(s => {
const next = update(s, actionQueue.current, reducerRef.current, emitter);
stateRef.current = next;
Expand Down
1 change: 1 addition & 0 deletions static/app/views/performance/newTraceDetails/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ export function TraceViewWaterfall(props: TraceViewWaterfallProps) {
) => {
if (searchingRaf.current?.id) {
window.cancelAnimationFrame(searchingRaf.current.id);
searchingRaf.current = null;
}

function done([matches, lookup, activeNodeSearchResult]) {
Expand Down
Loading
Loading