Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(trace) remove test skip and stop mocking console error #80158

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

test(trace) remove test skip and stop mocking console error #80158

wants to merge 41 commits into from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Nov 1, 2024 •
edited
Loading

Fixed all of the flaky tests inside trace view.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8158 1 8157 0
View the top 1 failed tests by shortest run time 
trace view search if search on load does not match anything, it does not steal focus or highlight first result
Stack Traces | 0.573s run time 
Error: expect(element).toHaveFocus()

Expected element with focus:
  <div class="TraceRow   " style="position: absolute; transform: translate(0px, 144px);" tabindex="-1"><div class="TraceLeftColumn"><div class="TraceLeftColumnInner" style="padding-left: 22px; transform: translateX(0px);"><div class="TraceChildrenCountWrapper"><span class="TraceVerticalConnector Orphaned" style="left: 0px;" /><button class="TraceChildrenCount"><div class="TraceChildrenCountContent" /><div class="TraceChildrenCountAction">+</div></button></div><img height="20" src="[object Object]" style="border-radius: 3px;" width="20" /><span class="TraceOperation">transaction-op-5</span><strong class="TraceEmDash"> — </strong><span class="TraceDescription">transaction-name-5</span></div></div><div class="TraceRightColumn"><div class="TraceBar" style="transform: matrix(1,0,0,1,0,0; --inverse-span-scale: 1; background-color: rgb(82, 74, 126);" /><div class="TraceBarDuration" style="color: white; transform: translateX(492px);">1.00s</div><button class="TraceArrow"><svg style="transform: rotate(-90deg);" viewBox="0 0 16 16"><path d="M14,11.75a.74.74,0,0,1-.53-.22L8,6.06,2.53,11.53a.75.75,0,0,1-1.06-1.06l6-6a.75.75,0,0,1,1.06,0l6,6a.75.75,0,0,1,0,1.06A.74.74,0,0,1,14,11.75Z" /></svg></button></div></div>
Received element with focus:
  <body><div><div class="css-18uu46s-TraceExternalLayout eez7g985"><header class="css-6v9tyg-Header e1hxddla7"><div class="css-1syqweg-HeaderContent e1hxddla6"><nav … /></div><div class="css-18hmlrw-HeaderActions e1hxddla5"><div … /></div></header><div class="css-1q4m53n-TraceInnerLayout eez7g984"><div class="css-1ojm1q2-TraceToolbar eez7g983"><div … /><button … /><button … /><div … /></div><div class="css-1j23fgp-TraceGrid eez7g982" style="grid-template-columns: 1fr minmax(0px, NaN%); grid-template-rows: 1fr auto;"><div … /><div … /></div></div></div></div></body>
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1266:23)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdkhan14 Abdkhan14 Abdkhan14 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasBa @Abdkhan14