Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTINUE filter_replace_character: Add plugin to replace a generic character in key names #2125

Closed
wants to merge 2 commits into from

Conversation

redradrat
Copy link

@redradrat redradrat commented Apr 21, 2020

This is a continuation of the changes in #1941

So, really, this is all @PettitWesley's work. Additions are basically just making the branch build - winging it and praying to holy cracking Yoda that this actually works. Just quickly verified it with a local cpu key character replacement. Worked well enough.

So I hope that opening a new PR like this is okay? I'll happily transfer my changes over to the initial branch. I'm not claiming any contributions here really.

@PettitWesley
Copy link
Contributor

PettitWesley commented Apr 22, 2020

@redradrat So the problem with my code is that it isn't recursive, it won't work for nested maps and arrays. I was originally planning to try to get it working non-recursively first, for top level keys, and test that out, but never even made it that far. Thanks for taking this over!

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 28, 2021
@patrick-stephens
Copy link
Contributor

@PettitWesley is this still active? The stale bot is not making it this far back so just reviewing manually.

@PettitWesley
Copy link
Contributor

@patrick-stephens I think my original comments still stand that this solution doesn't work since its not recursive (or can't process nested logs). I have heard many users request this though; I think someone should take this feature back up and drive it to completion.

@github-actions github-actions bot removed the Stale label Feb 22, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 23, 2022
@redradrat redradrat closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants