WIP: filter_replace_character: Add plugin to replace a generic character in key names #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I probably will not be able to work on this for a while- if anyone else wants to take a stab a finishing it, feel free to. |
PettitWesley
commented
Mar 13, 2020
Comment on lines
+159
to
+166
| if (k->type == MSGPACK_OBJECT_BIN) { | ||
| key_str = (char *) k->via.bin.ptr; | ||
| key_str_size = k->via.bin.size; | ||
| modify = FLB_TRUE; | ||
| } | ||
| else if (k->type == MSGPACK_OBJECT_STR) { | ||
| key_str = (char *) k->via.str.ptr; | ||
| key_str_size = k->via.str.size; |
There was a problem hiding this comment.
I think k is supposed to be key
PettitWesley
requested review from
edsiper,
fujimotos and
koleini
as code owners
|
@PettitWesley is this still in WIP or ready to be reviewed for a possible merge ? |
|
closing this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1538
Fixes #1305
Related to: