add cancel-stuck-transactions
#363
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
lib/evaluate.js
Outdated
| @@ -147,9 +149,10 @@ export const evaluate = async ({ | |||
|
|
|||
| const start = Date.now() | |||
| const buckets = createSetScoresBuckets(participants) | |||
| let tx | |||
| for (const [bucketIndex, bucket] of Object.entries(buckets)) { | |||
| try { | |||
There was a problem hiding this comment.
Here is how I understand your new version at the high level:
let tx
for (const [bucketIndex, bucket] of Object.entries(buckets)) {
tx = await ieContractWithSigner.setScores // etc.
}
tx.wait()This code will wait only for the last transaction created.
If that's intentional, then let's make it more obvious to the reader, please.
For example:
let lastTx
for (const [bucketIndex, bucket] of Object.entries(buckets)) {
const tx = await ieContractWithSigner.setScores // etc.
lastTx = tx
}
// add a comment explaining why we wait for the last transaction only
// and don't need to wait for other transactions
lastTx.wait()There was a problem hiding this comment.
This was even more broken. Each tx should be awaited and then marked as confirmed. Fixed 👍
There was a problem hiding this comment.
It may be worth creating a test to verify this works as intended. However, mocking all the dependencies to simulate two TXs running concurrently will require quite a bit of code, so it may not be the best use of our time right now.
|
Will now mirror this to |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Strange! In the example script of
I'll either add retry logic or let it fail more silently (the whole op will be retried anyway) |
I think I know what happens: When reading from postgres, it doesn't return a BigInt |
No description provided.