add expose FilFox error code #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
approved these changes
Sep 25, 2024
| throw new Error(`Filfox request failed with ${res.status}: ${(await res.text()).trimEnd()}`) | ||
| const err = new Error(`Filfox request failed with ${res.status}: ${(await res.text()).trimEnd()}`) | ||
| err.code = 'FILFOX_REQUEST_FAILED' | ||
| throw err | ||
| } | ||
| const body = await res.json() |
There was a problem hiding this comment.
Should we set err.code also when res.json() throws while reading the response body?
There was a problem hiding this comment.
We could, but it hasn't happened yet, and might never, so I would like not to spend the extra time on it
There was a problem hiding this comment.
But happy to review a PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for
spark-evaluateto ignore FilFox errors, expose them with their own code first.For filecoin-station/spark-evaluate#363 (comment)