Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2160 Update dependencies #35

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ engines:
enabled: true
rubocop:
enabled: true
channel: rubocop-0-80
channel: rubocop-1-23-0
ratings:
paths:
- "**.inc"
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.6', '2.7']
ruby-version: ['3.0', '3.1', '3.2']

steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Set frozen config to false
run: bundle config set --local frozen false
- name: Install Dependencies
run: bundle install
- name: Run tests
run: bundle exec rake
- name: Rubocop
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
inherit_from: .rubocop_todo.yml
AllCops:
TargetRubyVersion: 2.7
TargetRubyVersion: 3.1
Exclude:
- 'test/**/*'
- 'spec/**/*'
Expand Down
181 changes: 139 additions & 42 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-03-30 17:30:14 -0400 using RuboCop version 0.80.0.
# on 2023-11-17 20:09:11 UTC using RuboCop version 1.23.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleAlignWith, Severity.
# SupportedStylesAlignWith: start_of_line, begin
Layout/BeginEndAlignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 49
# Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause:
Expand All @@ -26,13 +34,7 @@ Layout/EmptyLineAfterGuardClause:
# Cop supports --auto-correct.
Layout/RescueEnsureAlignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'

# Offense count: 6
# Cop supports --auto-correct.
Lint/NonDeterministicRequireOrder:
Exclude:
- 'lib/fhir_stu3_models.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 2
# Cop supports --auto-correct.
Expand All @@ -41,13 +43,14 @@ Lint/ToJSON:
- 'lib/fhir_stu3_models/bootstrap/json.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 38
# Offense count: 37
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 405
Max: 407

# Offense count: 7
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
# IgnoredMethods: refine
Metrics/BlockLength:
Max: 70

Expand All @@ -57,31 +60,40 @@ Metrics/BlockNesting:
Max: 5

# Offense count: 6
# Configuration parameters: CountComments.
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
Max: 345
Max: 343

# Offense count: 25
# Offense count: 32
# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
Max: 69
Max: 77

# Offense count: 43
# Configuration parameters: CountComments, ExcludedMethods.
# Offense count: 44
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
Metrics/MethodLength:
Max: 127
Max: 125

# Offense count: 1
# Configuration parameters: CountComments.
# Configuration parameters: CountComments, CountAsOne.
Metrics/ModuleLength:
Max: 114

# Offense count: 24
# Offense count: 29
# Configuration parameters: IgnoredMethods.
Metrics/PerceivedComplexity:
Max: 72
Max: 80

# Offense count: 5
# Configuration parameters: EnforcedStyle, IgnoredPatterns.
# SupportedStyles: snake_case, camelCase
Naming/MethodName:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 4
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
Naming/MethodParameterName:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'
Expand All @@ -93,29 +105,67 @@ Naming/RescuedExceptionsVariableName:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'

# Offense count: 35
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: separated, grouped
Style/AccessorGrouping:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/template.rb'
- 'lib/fhir_stu3_models/fhir_ext/element_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 6
# Cop supports --auto-correct.
Style/CaseLikeIf:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/bootstrap/preprocess.rb'
- 'lib/fhir_stu3_models/bootstrap/xml.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'

# Offense count: 1
# Configuration parameters: .
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
EnforcedStyle: inline
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: nested, compact
Style/ClassAndModuleChildren:
Exclude:
- '.simplecov'

# Offense count: 17
Style/ClassVars:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
Style/CombinableLoops:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: Keywords, RequireColon.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
Style/CommentAnnotation:
Exclude:
- 'Guardfile'

# Offense count: 6
# Cop supports --auto-correct.
Style/CommentedKeyword:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 14
# Offense count: 15
# Configuration parameters: AllowedConstants.
Style/Documentation:
Exclude:
- 'spec/**/*'
- 'test/**/*'
- '.simplecov'
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
Expand All @@ -131,12 +181,11 @@ Style/Documentation:
- 'lib/fhir_stu3_models/fluentpath/expression.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 22
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false
Style/GlobalStdStream:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'

# Offense count: 29
# Cop supports --auto-correct.
Expand All @@ -150,30 +199,53 @@ Style/IfUnlessModifier:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
Style/MethodMissingSuper:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 1
Style/MissingRespondToMissing:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 9
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: AllowMethodComparison.
Style/MultipleComparison:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'

# Offense count: 2
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Style/OptionalBooleanParameter:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/template.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/OrAssignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/generator.rb'

# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantRegexpCharacterClass:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'

# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantRegexpEscape:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantSelfAssignment:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/element_definition.rb'

# Offense count: 16
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Expand All @@ -200,6 +272,31 @@ Style/SafeNavigation:
- 'lib/fhir_stu3_models/bootstrap/xml.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'

# Offense count: 9
# Cop supports --auto-correct.
Style/SlicingWithRange:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AllowModifier.
Style/SoleNestedConditional:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiterals:
Exclude:
- '.simplecov'

# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
Expand Down
8 changes: 4 additions & 4 deletions .simplecov
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
require 'simplecov'
SimpleCov.command_name 'Unit Tests'
SimpleCov.start do
add_filter "test/"
add_group "Library", "lib"
end
# SimpleCov.start do
# add_filter "test/"
# add_group "Library", "lib"
# end

class SimpleCov::Formatter::QualityFormatter
def format(result)
Expand Down
Loading
Loading