FI-2160 Update dependencies #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would like another set of eyes on why codeclimate is failing. Seems like it's mad that we left TODO comments in, but I think those comments are generated by rubocop to describe the keywords it's looking for? |
|
Replaced by #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion of FI_2160 for this Repo.
.simplecovhas had some lines commented out to prevent errors described in the Jira ticket.Have also brought rubocop up to a version that can handle the newer versions of ruby. Had to add some steps to the job process as well, as it was having issues with the gemfile being frozen.