Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge SPDL_HOLD_GIL and NB_FREE_THREADED macro (#223)" #241

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Revert "Merge SPDL_HOLD_GIL and NB_FREE_THREADED macro (#223)" #241

merged 2 commits into from
Oct 6, 2024

Commits on Oct 4, 2024

  1. Revert "Merge SPDL_HOLD_GIL and NB_FREE_THREADED macro (#223)" 

    This reverts commit fe21d11.

In Python 3.13 there are three kinds of mode

1. Built with GIL enabled
2. Built with GIL disabled, executed with GIL enabled
3. Built with GIL disabled, executed with GIL disabled

The runtime GIl is determined either by flag `-Xgil`, env var `PYTHON_GIL`,
or whether a module complied with GIL enabled is imported or not.

So keeping a separate SPDL_HOLD_GIL option, allows to support
all the build modes.
    @mthrok
    mthrok committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    68f8fc4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into HOLD_GIL

    @mthrok
    mthrok authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    afea80b View commit details
    Browse the repository at this point in the history