Revert "Merge SPDL_HOLD_GIL and NB_FREE_THREADED macro (#223)" #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fe21d11. In Python 3.13 there are three kinds of mode 1. Built with GIL enabled 2. Built with GIL disabled, executed with GIL enabled 3. Built with GIL disabled, executed with GIL disabled The runtime GIl is determined either by flag `-Xgil`, env var `PYTHON_GIL`, or whether a module complied with GIL enabled is imported or not. So keeping a separate SPDL_HOLD_GIL option, allows to support all the build modes.
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fe21d11.
In Python 3.13 there are three kinds of mode
The runtime GIl is determined either by flag
-Xgil, env varPYTHON_GIL, or whether a module complied with GIL enabled is imported or not.So keeping a separate
SPDL_HOLD_GILoption, allows to support all the build modes.