Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findings from Dmitry's review #508

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Fix findings from Dmitry's review #508

merged 21 commits into from
Sep 25, 2024

Commits on Sep 16, 2024

  1. Start to fix findings from Dmitry's review

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    518b2ea View commit details
    Browse the repository at this point in the history

  2. Replace int variables with size_t variables

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2c03989 View commit details
    Browse the repository at this point in the history

  3. Optimize away a blst_fr_eucl_inverse call

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1c67090 View commit details
    Browse the repository at this point in the history

  4. Precompute reverse-bits-limited cell indices

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3187576 View commit details
    Browse the repository at this point in the history

  5. Fix mistake

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e328423 View commit details
    Browse the repository at this point in the history

  6. Remove accidental line break

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    742fec2 View commit details
    Browse the repository at this point in the history

  7. Add asserts for domain string lengths

    @jtraglia
    jtraglia committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37eea2c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Revert changes to fr_batch_inv & bytes_from_uint64

    @jtraglia
    jtraglia committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    116ba8f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Rename inv_len to inv_n

    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    87068fb View commit details
    Browse the repository at this point in the history

  2. Move FIELD_ELEMENTS_PER_EXT_BLOB to cell.h 

    Also add new EXPANSION_FACTOR constant.
    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7cf99f2 View commit details
    Browse the repository at this point in the history

  3. Clean up toeplitz_coeffs_stride

    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c9f6845 View commit details
    Browse the repository at this point in the history

  4. Rename field_element to element_bytes

    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    df5e7e5 View commit details
    Browse the repository at this point in the history

  5. Maybe improve readability for coset factors

    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8f381e9 View commit details
    Browse the repository at this point in the history

  6. Add length info to comments

    @jtraglia
    jtraglia committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8c9d0ab View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Add punctuation to new comment 

    Co-authored-by: Benedikt Wagner <[email protected]>
    @jtraglia @b-wagn
    jtraglia and b-wagn authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7a0d72e View commit details
    Browse the repository at this point in the history

  2. Fix length comment 

    Co-authored-by: Benedikt Wagner <[email protected]>
    @jtraglia @b-wagn
    jtraglia and b-wagn authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2a62ef3 View commit details
    Browse the repository at this point in the history

  3. Replace / 2 with / EXPANSION_FACTOR

    @jtraglia
    jtraglia committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    021730e View commit details
    Browse the repository at this point in the history

  4. Remove EXPANSION_FACTOR constant

    @jtraglia
    jtraglia committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4e4ce18 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Improve coset factor computation (#7)

    @asn-d6
    asn-d6 authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    64b156c View commit details
    Browse the repository at this point in the history

  2. Add extra assert & fix formatting

    @jtraglia
    jtraglia committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    94c1314 View commit details
    Browse the repository at this point in the history

  3. Format c params

    @jtraglia
    jtraglia committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    353cb4f View commit details
    Browse the repository at this point in the history