Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findings from Dmitry's review #508

Merged
merged 21 commits into from
Sep 25, 2024
Merged

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Sep 16, 2024

This PR is a work in progress. It does the following things:

  • Update com.diffplug.spotless to work with Java 22.
  • Rename compute_fk20_proofs to compute_fk20_cell_proofs.
  • Hardcode compute_fk20_cell_proofs to accept FIELD_ELEMENTS_PER_BLOB length poly.
  • Add instructions to install build in Python bindings.
  • Add comment about fr_is_null edge case in recovery.
  • Handle zero-length inputs to FFT functions.
  • Optimize calculation for coset_factor_pow.
  • Replace signed integers with unsigned types.
  • Assert that the domain strings are the correct length.
  • Add precomputed array of RBL cell indices.

Big thanks to @khovratovich 🙏

If we choose to, we can do larger renaming fixes in a separate PR.

@jtraglia jtraglia marked this pull request as ready for review September 16, 2024 22:25
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Highlighting some things that can be improved IMO.

src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip4844/eip4844.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
Copy link
Contributor

@b-wagn b-wagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jtraglia and also @khovratovich !

I left some comments, but most of it looks good :)

src/eip7594/cell.c Outdated Show resolved Hide resolved
src/eip7594/fk20.c Outdated Show resolved Hide resolved
src/eip7594/fft.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Show resolved Hide resolved
src/eip7594/cell.h Outdated Show resolved Hide resolved
src/eip7594/poly.c Outdated Show resolved Hide resolved
Copy link
Contributor

@b-wagn b-wagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

Co-authored-by: Benedikt Wagner <[email protected]>
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot everyone here!

@jtraglia jtraglia merged commit cee63f6 into ethereum:main Sep 25, 2024
41 checks passed
@jtraglia jtraglia deleted the dmitry-review branch September 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants