Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

materialize-postgres: materialize UUID formatted strings as UUID columns #1993

Merged
merged 2 commits into from
Sep 30, 2024
Merged

materialize-postgres: materialize UUID formatted strings as UUID columns #1993

merged 2 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. materialize-postgres: materialize UUID formatted strings as UUID columns 

    Materialize UUID formatted strings as UUID columns, but continue to allow TEXT
columns to validate for these fields since there are pre-existing columns and we
don't want to force a backfill of them. Transferring the values of the fields is
the same if they are UUID columns vs. TEXT columns.
    @williamhbaker
    williamhbaker committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    73078cc View commit details
    Browse the repository at this point in the history

  2. materialize-postgres: create load table columns based on existing tab… 

    …le key columns

In scenarios where there may be more than one allowed pre-existing column type,
the load table must be created with a column type corresponding to the existing
table column to ensure that join query comparisons work correctly.

This required threading through a hydrated `InfoSchema` to the `NewTransactor`
constructor, and that has been added as a generally available capability. This
simplifies `materialize-redshift` and `materialize-mysql` which were already
making an `InfoSchema` in their own bespoke way, and eventually most other
materializations will probably need to do something like `materialize-postgres`
does with its load table columns.

Currently the only other materialization that matches its load table column
types to the existing table column types is `materialize-bigquery`, and it may
be useful to refactor this handling in terms of the `InfoSchema` at some point
as well.
    @williamhbaker
    williamhbaker committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1b9d6ae View commit details
    Browse the repository at this point in the history