materialize-postgres: materialize UUID formatted strings as UUID columns #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Materialize UUID formatted strings as UUID columns, but continue to allow TEXT columns to validate for these fields since there are pre-existing columns and we don't want to force a backfill of them. Transferring the values of the fields is the same if they are UUID columns vs. TEXT columns.
…le key columns In scenarios where there may be more than one allowed pre-existing column type, the load table must be created with a column type corresponding to the existing table column to ensure that join query comparisons work correctly. This required threading through a hydrated `InfoSchema` to the `NewTransactor` constructor, and that has been added as a generally available capability. This simplifies `materialize-redshift` and `materialize-mysql` which were already making an `InfoSchema` in their own bespoke way, and eventually most other materializations will probably need to do something like `materialize-postgres` does with its load table columns. Currently the only other materialization that matches its load table column types to the existing table column types is `materialize-bigquery`, and it may be useful to refactor this handling in terms of the `InfoSchema` at some point as well.
williamhbaker
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Materialize UUID formatted strings as UUID columns, but continue to allow TEXT columns to validate for these fields since there are pre-existing columns and we don't want to force a backfill of them. Transferring the values of the fields is the same if they are UUID columns vs. TEXT columns.
Going forward new or re-backfilled tables will have UUID formatted strings materialized as UUID columns.
Also: Create load tables for
materialize-postgreswith column DDL based on the key columns of the target tables. This is required for join query comparisons to work correctly for pre-existing tables that have UUID fields materialized as TEXT columns. Most of the diff is a result of this change.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is