-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p4): Added avoid-tear feature and audio-related code. (BSP-560) #401
Conversation
382c841
to
378ab88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Horion0415 thank you very much for the PR! I left few nitpicks/questions
@espzav PTAL and the esp_lvgl_port part :)
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4_function_ev_board.h
Outdated
Show resolved
Hide resolved
bsp/esp32_p4_function_ev_board/include/bsp/esp32_p4_function_ev_board.h
Outdated
Show resolved
Hide resolved
@Horion0415 SD card changes have been merged in #405, please rebase on top of it. Sorry for the trouble! |
c0a0b73
to
90db0a0
Compare
90db0a0
to
2fc3f8a
Compare
c18c16f
to
396a35d
Compare
@Horion0415 Sorry for my mistake, I overlooked - there is missing update version of |
396a35d
to
417fddc
Compare
Alright, that was my oversight. Considering the significant modifications to the esp_lvgl_port this time, along with the addition of some new features, I have bumped the minor version. I'm not sure if this is appropriate? |
Thank you very much! It is ok, the major version is usually the big change (breaking change) |
417fddc
to
44efecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ESP-BSP Pull Request checklist
Change description