Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to request multiple framebuffers on noglib version (BSP-566) #412

Open
1 task done
Spritetm opened this issue Oct 22, 2024 · 4 comments
Open
1 task done

Comments

@Spritetm
Copy link
Member

Related area

Display

Hardware specification

BSP package P4-ev-board

Is your feature request related to a problem?

For a game port, I need multiple framebuffers I can draw to. The LVGL version of the BSP allows me to select that, but in noglib, there is no way to get more than 1 framebuffer

Describe the solution you'd like

bsp_display_config_t could get a flag or integer field indicating multiple framebuffers are requested; bsp_display_new would need to honour that.

Describe alternatives you've considered

No response

Additional context

No response

I have checked existing list of Feature requests and the Contribution Guide

  • I confirm I have checked existing list of Feature requests and Contribution Guide.
@github-actions github-actions bot changed the title Add method to request multiple framebuffers on noglib version Add method to request multiple framebuffers on noglib version (BSP-566) Oct 22, 2024
@espzav
Copy link
Collaborator

espzav commented Oct 22, 2024

You can select it in menuconfig:
image

@Spritetm
Copy link
Member Author

Spritetm commented Oct 23, 2024

@espzav I don't think so. I can't really see where that option comes from in your screenshot (current bsp code only has that option in bsp/esp32_s3_lcd_ev_board/Kconfig ), and the option there is CONFIG_BSP_DISPLAY_LVGL_AVOID_TEAR=y which as the name suggests is an option that involves LVGL (and is only used here which indeed is LVGL-specific code). As mentioned before, I'm specifically using the noglib version of the BSP, which does not use LVGL and has all related code ifdef'fed out.

@espzav
Copy link
Collaborator

espzav commented Oct 23, 2024

@Spritetm Oh sorry, it will be added in this PR: #401 and it is not merged yet. It will be merged soon (I hope today). I think that this option should be there for noglib too.

@espzav
Copy link
Collaborator

espzav commented Oct 23, 2024

@Spritetm The mentioned PR was merged today. Is it ok? Can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants